[Webkit-unassigned] [Bug 80005] Implement strict testing criterion for callback function definition

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 01:25:46 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80005





--- Comment #22 from Yanbin <yanbin.zhang at intel.com>  2012-03-07 01:25:45 PST ---
(In reply to comment #21)
> (In reply to comment #20)
> > I only find one peerconnection-argument-types-expected.txt
> > at ./LayoutTest/fast/mediastream/peerconnection-argument-types-expected.txt
> 
> Yes, because CodeGeneratorJS.pm and CodeGeneratorV8.pm have been behaving the same. Your patch is going to change their behaviors and generate two kind of results, one for chromium and the other for other platforms.

(In reply to comment #21)
> (In reply to comment #20)
> > I only find one peerconnection-argument-types-expected.txt
> > at ./LayoutTest/fast/mediastream/peerconnection-argument-types-expected.txt
> 
> Yes, because CodeGeneratorJS.pm and CodeGeneratorV8.pm have been behaving the same. Your patch is going to change their behaviors and generate two kind of results, one for chromium and the other for other platforms.

(In reply to comment #20)
> (In reply to comment #18)
> > (From update of attachment 130565 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=130565&action=review
> > 
> > > LayoutTests/ChangeLog:8
> > > +        * fast/mediastream/peerconnection-argument-types-expected.txt:
> > 
> > As I mentioned, I guess you need to add the result of chromium to platform/chromium/fast/mediastream/peerconnection-argument-types-expected.txt, and update the result of other platforms (e.g. Mac) in fast/mediastream/peerconnection-argument-types-expected.txt. These two results are different, right?
> 
> I only find one peerconnection-argument-types-expected.txt
> at ./LayoutTest/fast/mediastream/peerconnection-argument-types-expected.txt
> 
> for original design:
> Philippe’s test result(on GTK environment) ,new webkitPeerConnection("TURNS NONE",{}) will throw exception .
> new webkitPeerConnection("TURNS NONE",{}) will not throw exception on V8 environment(chromium).

If this patch check in 
Philippe’s test result(on GTK environment) ,new webkitPeerConnection("TURNS NONE",{}) will throw exception .
> new webkitPeerConnection("TURNS NONE",{}) will also throw exception on V8 environment(chromium).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list