[Webkit-unassigned] [Bug 80474] Web Inspector: Cannot insert right curly bracket on some keyboards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80474


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130523|                            |review?
               Flag|                            |




--- Comment #2 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-03-07 01:11:08 PST ---
(From update of attachment 130523)
View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review

> Source/WebCore/inspector/front-end/inspector.js:720
> +    var hasCtrlOrMeta = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && !event.altKey;

I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to differentiate it from the "normal" hasCtrlOrMeta checks around the code. Otherwise looks good; thanks for diagnosing and fixing this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.