[Webkit-unassigned] [Bug 80005] Implement strict testing criterion for callback function definition

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 23:58:23 PST 2012


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #130557|review?                     |review+
               Flag|                            |

--- Comment #10 from Kentaro Hara <haraken at chromium.org>  2012-03-06 23:58:23 PST ---
(From update of attachment 130557)
View in context: https://bugs.webkit.org/attachment.cgi?id=130557&action=review

Looks OK.

>> Aren't there any tests that are affected by this change?
>--- I only find this test case now. And i have run test cases via "new-run-webkit-tests chromium ". no other test cases was found.

What's "chromium "? Anyway, the commit queue will tell you if there are any failing tests. If you want to commit it, please change "cq:" to "cq:?".

> Source/WebCore/ChangeLog:7
> +

You can write the comment "Implement strict testing criterion for callback function definition.Callback function should be defined as Function strictly instead of Object. While, IsFunction is inherited from IsObject .Existing code only check callback function should be an object. This patch is implement strict testing criterion for callback function definition." here. Also it might be a good idea to add a link to the Web IDL spec that supports this change.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list