[Webkit-unassigned] [Bug 80137] [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80137





--- Comment #5 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-03-06 23:53:44 PST ---
(In reply to comment #4)
> (From update of attachment 130314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review
> 
> LGTM.
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439
> > +void LayoutTestController::setPopupBlockingEnabled(bool flag)
> 
> Woudl be better to use a nicer name.  Like enablePopupBlocking.

Yes, but this implements a common interface for all WebKit ports (Tools/DumpRenderTree/LayoutTestController.h) We can change it while general refactoring of DRT in my opinion :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.