[Webkit-unassigned] [Bug 79880] [WebSocket]Optimize the masking/unmasking operation by 64-bit data type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 19:20:31 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=79880





--- Comment #20 from joey <li.yin at intel.com>  2012-03-06 19:20:30 PST ---

(In reply to comment #18)
> You still need to convice reviewers that this patch is useful and your algorithm gives us perf boost. Otherwise the increased code complexity (maintenance cost) does not worth it. We worked a lot of such algorithm before and unfortunately many of them are turned out to be not good enough. Many times the memory reads and writes are the bottleneck for such simple algorithms so an optimized version version gives only a minor speedup, but makes the code difficult to maintain. So please tell us your measurements, and also mention them in the changelog.

Thanks for your review and good advice, I have updated the patch already, and add the test result in the ChangeLog, please have a check again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list