[Webkit-unassigned] [Bug 80430] [BlackBerry] Set correct ResourceRequest target type.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 18:13:06 PST 2012


--- Comment #3 from Lyon Chen <liachen at rim.com>  2012-03-06 18:13:05 PST ---
(In reply to comment #2)
> The HashMap needs to be static for sure.
> You need to make it static, otherwise you keep allocating it each time the function is called.

Yes, this is an error, will fix.

> Maybe better not include the commented three lines.

Will remove them.

> Can you explain what and why it is too late?

In FrameLoaderClientBlackBerry::dispatchWillSendRequest() request.initializePlatformRequest() is called before the target type setting codes. And the target type is only referred to by us in initializePlatformRequest(), so it doesn't make sense to change the target type after it is used already.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list