[Webkit-unassigned] [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9767





--- Comment #31 from Tim Horton <timothy_horton at apple.com>  2012-03-06 17:38:21 PST ---
(From update of attachment 128248)
View in context: https://bugs.webkit.org/attachment.cgi?id=128248&action=review

> Source/WebCore/rendering/RenderObject.cpp:2593
> +    Settings* settings = document()->settings();
> +
>      // If we're not in a window (i.e., we're dormant from being put in the b/f cache or in a background tab)
>      // then we don't want to render either.
> -    return !document()->inPageCache() && !document()->view()->isOffscreen();
> +    return !document()->inPageCache() && !document()->view()->isOffscreen() && settings && settings->allowAnimatedImages();

I haven't looked at the rest of the patch, but this caught my eye. Presumably you're expecting there's some potential situation where settings could be null, since you added a null check.

Does it make sense, though, to change the return value of willRenderImage() in that case? (i.e. if (!document()->inPageCache() && !document()->view()->isOffscreen()) is true, but settings is null, you will now return false instead of true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.