[Webkit-unassigned] [Bug 79961] [chromium] Font fallback in cr-win is wrong for string contains zero-width-space

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 17:32:22 PST 2012


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #130486|                            |review?
               Flag|                            |

--- Comment #3 from Xiaomei Ji <xji at chromium.org>  2012-03-06 17:32:22 PST ---
Created an attachment (id=130486)
 --> (https://bugs.webkit.org/attachment.cgi?id=130486&action=review)
patch w/ layout test

Thanks for the review!

(In reply to comment #2)
> (From update of attachment 129728 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129728&action=review
> If possible, I'd rather add a layout test that does not rely on the actual font used. Revising zero-width-characters-complex-script.html would be better, wouldn't it?

Yes. Done.

> > Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp:889
> > +            bool treatAsZeroWidthSpace = c == zeroWidthSpace || Font::treatAsZeroWidthSpaceInComplexScript(c);
> Can you add ZWSP to the set of characters returned by treatAsZeroWidth....?

Looks like it is save to add ZWSP as one of the characters to be treatedAsZeroWidthSpaceInComplexSccipt. Done.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list