[Webkit-unassigned] [Bug 80430] [BlackBerry] Set correct ResourceRequest target type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80430


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130406|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-03-06 14:26:31 PST ---
(From update of attachment 130406)
View in context: https://bugs.webkit.org/attachment.cgi?id=130406&action=review

The HashMap needs to be static for sure.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:92
> +    MimeTypeResourceRequestTypeMap* map = 0;

You need to make it static, otherwise you keep allocating it each time the function is called.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:114
> +            // map->add(String(""), ResourceRequest::TargetIsMedia);

Maybe better not include the commented three lines.

> Source/WebKit/blackberry/ChangeLog:8
> +        Removed unused code in dispatchWillSendRequest(), they are too late!

Can you explain what and why it is too late?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.