[Webkit-unassigned] [Bug 77437] freetype port: font fallback mechanism can try harder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77437


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126260|review?                     |review-
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2012-03-06 07:13:24 PST ---
(From update of attachment 126260)
View in context: https://bugs.webkit.org/attachment.cgi?id=126260&action=review

Looks good, but I think a slightly different design may be in order here.

> Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:115
> +    const FontFamily* family = &fontDescription.family();
> +    if (family->family().length())
> +        result = getCachedFontData(fontDescription, family->family(), false, Retain);
> +

Instead of adding the idea of an in-exact match to the platform-independent code, I think it's better to first ask Fontconfig what the proper fallback font is and then get that font explicitly from the font cache.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.