[Webkit-unassigned] [Bug 80413] Add SVGRenderingContext and move there the context related code from SVGRenderSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80413


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130368|review?                     |review+
               Flag|                            |




--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2012-03-06 07:07:41 PST ---
(From update of attachment 130368)
View in context: https://bugs.webkit.org/attachment.cgi?id=130368&action=review

Looks great! r=me, assuming no regressions.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:38
> +#if ENABLE(FILTERS)

No need to guard class forwards IIRC.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:75
> +    bool isRenderingPrepared() { return m_renderingFlags & RenderingPrepared; }

Could be const.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:79
> +    // we record all successful steps.

No need to wrap lines here, eh?

> Source/WebCore/rendering/svg/SVGRenderingContext.h:91
> +        | EndOpacityLayer | EndShadowLayer | EndFilterLayer;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.