[Webkit-unassigned] [Bug 79795] Unreleased gst_object_reference to audio sink in MediaPlayerPrivateGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79795


David Corvoysier <david.corvoysier at orange.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129267|0                           |1
        is obsolete|                            |
 Attachment #130357|                            |review?, commit-queue?
               Flag|                            |




--- Comment #15 from David Corvoysier <david.corvoysier at orange.com>  2012-03-06 04:49:31 PST ---
Created an attachment (id=130357)
 --> (https://bugs.webkit.org/attachment.cgi?id=130357&action=review)
New patch using GRefPtr<GstElement>

Bug fix: Used a GRefPtr to hold the reference to the audio sink instead of a GstElement*.
Code cleanup: Used the same pattern for webkit web source and removed explicit gst_unref in destructor.

Tested it on a typical video page, with GST_DEBUG=GST_REFCOUNTING:5, and verified both audio sink and webkit web source are properly released.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.