[Webkit-unassigned] [Bug 63919] webkit-gtk compile failure with Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63919





--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2012-03-06 04:44:15 PST ---
(From update of attachment 102346)
View in context: https://bugs.webkit.org/attachment.cgi?id=102346&action=review

> webkit-1.4.2/Source/WebCore/plugins/gtk/PluginViewGtk.cpp:830
> +#if defined(GDK_WINDOWING_WIN32) && !defined(GTK_API_VERSION_2)
> +        setPlatformWidget(0);

This should be #if PLATFORM(WINDOWS) instead of GDK_WINDOWING_WIN32, I think.

1.4.2 is very old, but this patch seems to be still necessary. It needs to be fixed to build on master, and have a ChangeLog entry like kalev mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.