[Webkit-unassigned] [Bug 9223] Resize handles should be on the lower left corner for rtl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9223


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130086|0                           |1
        is obsolete|                            |
 Attachment #130351|                            |review?
               Flag|                            |




--- Comment #24 from Hironori Bono <hbono at chromium.org>  2012-03-06 04:15:42 PST ---
Created an attachment (id=130351)
 --> (https://bugs.webkit.org/attachment.cgi?id=130351&action=review)
A quick fix v2 (fixed the layout test)

Greetings Tony,

Thanks for your review and comment.
Sorry, this test failure is totally my fault. The previous test does not work well on Chromium DumpRenderTree due to a variable-name conflict: this uses a variable 'top', which causes a conflict with 'window.top'. (I have tested my previous test only on Safari DumpRenderTree with WTF_USE_RTL_SCROLLBAR enabled.) I have updated the layout test. (It should work well with Chromium DumpRenderTree.)

Regards,

Hironori Bono

(In reply to comment #23)
> (From update of attachment 130086 [details])
> This seems fine.  Is the test failing because RTL_SCROLLBAR isn't defined?  Please fix the test before landing.
> 
> Aharon makes a lot of good points in comment #20, but we should file a new bug for those issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.