[Webkit-unassigned] [Bug 79495] [GTK] FrameLoader signals: gtk-doc fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79495


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-06 00:12:11 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > The main problem for me with the patch is the lack of unit tests, but I would be happy just if the documentation is fixed.
> 
> That patch unskipped a good number of layout tests though and that new API is used in DRT. I don't see the point of adding unit tests in that case.

If the patch had included unit tests, you would have noticed that length-received is not the length of the resource, but the length of the data chunk received and that it can be emitted multiple times, for example. Unit test are useful to make sure that API works for multiple uses, I haven't looked at how DRT use the API, but I guess it doesn't use all the API (signals and methods) exposed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.