[Webkit-unassigned] [Bug 78575] Web Inspector: Hide dock button when not allowed to dock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 22:43:27 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78575





--- Comment #23 from Pavel Feldman <pfeldman at chromium.org>  2012-03-05 22:43:27 PST ---
(In reply to comment #22)
> > Changing the visibility of the button might be a bad idea - we sometimes rely upon the number of buttons (to position view's statusbar when resizing the sidebar). could you disable it instead?
> 
> Sorry for crying out loud. It is just that canAttach and setDockingUnavailable in the same interface made me go wild.

To clarify: canAttachWindow in the interface meant that we still do synchronous calls with return valus (from the front-end into the embedder). Which was my major concern expressed in the comment#2. It turned out that Joe's latest solution did not need really it since he was already using direct calls on the InspectorFrontendAPI as I was suggesting. I already raised the flag by the time I reached the InspectorFrontendAPI part in my review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list