[Webkit-unassigned] [Bug 78575] Web Inspector: Hide dock button when not allowed to dock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78575





--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2012-03-05 17:16:37 PST ---
(From update of attachment 130237)
View in context: https://bugs.webkit.org/attachment.cgi?id=130237&action=review

>> Source/WebCore/page/FrameView.cpp:2336
>> +            InspectorInstrumentation::didResizeMainFrame(m_frame.get());
> 
> This might not be the main frame. Do you need a check here?
> 
> if (Page* page = m_frame->page()) {
>     if (page->mainFrame() == m_frame) { … }
> }

Ahh, you're correct. I actually had that and lost it when I rebased this from last week. Good catch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.