[Webkit-unassigned] [Bug 79876] [BlackBerry] Upstream WebGL related files from platform/graphics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79876


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129701|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-03-05 12:00:40 PST ---
(From update of attachment 129701)
View in context: https://bugs.webkit.org/attachment.cgi?id=129701&action=review

Looks good, some more cleanup can be done.

> Source/WebCore/platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:66
> +// FIXME: The last two params are ignored for the BlackBerry platform. Is this still true?

FIXME: fix comment. Last two params?

> Source/WebCore/platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:113
> +        return false;

I'd add an empty line here.

> Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:36
> +#include "ChromeClientBlackBerry.h"

Both chrome includes do not seem used? In general check all includes.

> Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:70
> +    m_context = BlackBerry::Platform::Graphics::createWebGLContext();

Could move into initializer list above as well.

> Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:154
> +    return m_texture;

All above one-liners are candidates for inlining in the header.

> Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:173
> +            unsigned char *destRow = tempPixels + (imageWidth * 4 * (imageHeight-y-1));

Watch spacing -> (imageHeight-y-1)

> Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:207
> +}

Could be put in header as well.

> Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:32
> +    , m_needsDisplay(0)

Huh?

> Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:58
> +    // while we are drawing into it

Can be made one line, with a period at end.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.