[Webkit-unassigned] [Bug 80042] [WK2] run-perf-tests should be able to run with WTR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80042





--- Comment #5 from Zan Dobersek <zandobersek at gmail.com>  2012-03-05 11:04:15 PST ---
(From update of attachment 129741)
View in context: https://bugs.webkit.org/attachment.cgi?id=129741&action=review

>> Tools/WebKitTestRunner/TestController.cpp:546
>> +    platformRunUntil(done, timeoutDuration == ShortTimeout ? m_shortTimeout : m_longTimeout, shouldTimeout);
> 
> Instead of adding an extra parameter, perhaps it would be better to add another value to the enum so there is ShortTimeout, LongTimeout and NoTimeout.

Noted.

>> Tools/WebKitTestRunner/TestController.h:74
>> +    void platformRunUntil(bool& done, double timeout, bool shouldTimeout);
> 
> Instead of adding another parameter, perhaps you could just have a constant == -1 that signifies no timeout. Another option would be to add another calld platformRun that didn't timeout.

platformRun would probably introduce some code duplication, so I'll just use a negative constant to indicate no timeout and check for that.

>> Tools/WebKitTestRunner/TestInvocation.cpp:153
>> +    WKDictionaryAddItem(beginTestMessageBody.get(), useTimeoutWatchdogKey.get(), useTimeoutWatchdogValue.get());
> 
> Probably better to refer to this thing consistently ala useWaitToDumpWatchdogTimer.

I'll just put (u/U)seWaitToDumpWatchdogTimer everywhere - consistency at its best.

>> Tools/WebKitTestRunner/mac/TestControllerMac.mm:56
>> +    // FIXME: No timeout should occur if shouldTimeout is false (necessary when running performance tests).
> 
> It seems quite possible to add support here.

I'm not familiar enough with Objective C or Cocoa to be comfortable making these changes. I can give it a shot, but I would rather open a bug for this problem, as you suggested doing for the Windows' TestController.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.