[Webkit-unassigned] [Bug 79880] [WebSocket]Optimize the masking/unmasking operation by SSE2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79880





--- Comment #11 from Yuta Kitamura <yutak at chromium.org>  2012-03-05 10:20:37 PST ---
I'm also surprised to see this patch, but it's somewhat understandable that the frame masking code is a hot path. I'm not an expert of SSE2 operations so I'm not qualified to review the patch, though.

A few thoughts:
* Current code masks frames for each byte (char). Have you tried to mask frames for each machine word (32-bit or 64-bit)? I believe that would improve the performance, even without SSE.

* It may be a good idea to add some WebSocket tests under PerformanceTests/.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.