[Webkit-unassigned] [Bug 80119] [EFL] Add OwnPtr specialization for Ecore_Timer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80119


Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130066|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-03-05 10:06:08 PST ---
(From update of attachment 130066)
View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review

> Source/WebCore/platform/efl/SharedTimerEfl.cpp:41
> -static Ecore_Timer *_sharedTimer = 0;
> +static OwnPtr<Ecore_Timer> sharedTimer;

Declaring a static object like this makes the code prone to all sorts of problems, since you can't guarantee when this object will be initialized. Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure the object is created on first use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.