[Webkit-unassigned] [Bug 80271] [GTK] Use a single signal for script dialogs in WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80271





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-03-05 09:18:52 PST ---
(From update of attachment 130102)
View in context: https://bugs.webkit.org/attachment.cgi?id=130102&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:149
>>> +    delete dialog;
>> 
>> Perhaps it makes sense to use the slab allocator and placement new syntax here?
> 
> It doesn't really matter, this will never be used, but we need to give a copy and free func for boxed types. The struct is stack allocated before emitting the signal and the signal parameter is  G_SIGNAL_TYPE_STATIC_SCOPE.

Perhaps it would make sense to use ASSERT_NOT_REACHED here then?

>>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554
>>> + * signal sets %TRUE when OK button is clicked and %FALSE otherwise.
>> 
>> Nit: the Ok button
> 
> Ok.

Sorry, I meant "the OK button" here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.