[Webkit-unassigned] [Bug 79886] ShadowRoot should have activeElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79886





--- Comment #6 from Hayato Ito <hayato at chromium.org>  2012-03-05 01:51:49 PST ---
(From update of attachment 130076)
View in context: https://bugs.webkit.org/attachment.cgi?id=130076&action=review

> Source/WebCore/dom/TreeScope.cpp:177
> +    while (node->treeScope() != document) {

This looks wrong for me. This loop should be:

  while (node->treeScope() != this)

isn't it?
In your patch, shadowRoot.activeElement returns the same node of document.activeElement().

> LayoutTests/fast/dom/shadow/shadow-root-activeElement.html:42
> +shouldBe("shadowRoot.activeElement", "shadowHost");

I am afraid you misunderstand the spec. In this case, shadowRoot.activeElement should be 'p1', not shadowHost.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.