[Webkit-unassigned] [Bug 79877] [GTK] zlib link error with --enable-webkit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79877


Joone Hur <joone.hur at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #8 from Joone Hur <joone.hur at collabora.co.uk>  2012-03-04 20:17:24 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 130024 [details] [details])
> > Is it enough to add it to webkit2_tests_ldadd and not Programs_WebKitTestRunner_LDADD? It's weird that we need to keep adding these libraries to WebKitTestRunner since it doesn't use them directly.
> 
> Oh yes, right! For instance the gst libs are in webkit2_tests_ldadd but not in Programs_WebKitTestRunner_LDADD.
> 
> Joone, can you double-check the WebKitTestRunner/GNUmakefile.am is not needed please?

I've found another link problem in Source/WebKit2/GNUmakefile.am as follows:
--- a/Source/WebKit2/GNUmakefile.am
+++ b/Source/WebKit2/GNUmakefile.am
@@ -1325,8 +1325,7 @@ libWebCoreGtk2_la_CPPFLAGS = \
    $(SQLITE3_CFLAGS) \
    $(UNICODE_CFLAGS) \
    $(XRENDER_CFLAGS) \
-   $(XT_CFLAGS) \
-   $(ZLIB_LIBS)
+   $(XT_CFLAGS)

ZLIB_LIBS is added improperly to here. So if we remove it, we should add it to Programs_WebKitTestRunner_LDADD

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.