[Webkit-unassigned] [Bug 80211] [EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80211


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129999|review?                     |review-
               Flag|                            |




--- Comment #4 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-03-03 07:46:56 PST ---
(From update of attachment 129999)
View in context: https://bugs.webkit.org/attachment.cgi?id=129999&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:58
> +    if (m_evasGL) {

Style: early-return here.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:87
> +    m_context = evas_gl_context_create(m_evasGL, 0);

What does 0 stand for? comment.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:102
> +    int x = 0, y = 0, width = 1, height = 1;

separate lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.