[Webkit-unassigned] [Bug 79896] [CMake][DRT] Add WebCoreTestSupport

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79896





--- Comment #11 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-03-02 04:46:44 PST ---
Yes, (In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Please look at the _new_ patch at that bug. I requested to split the original patch there to make "atomic" commits.
> > 
> > Yeah, but my point is that there are two patches from Kangil and another one from Thiago, and they don't completely overlap: Thiago's patch doesn't split WebCoreTestSupport into a separate library but updates the skipped list, which neither of Kangil's patches do. We need to coordinate this better.
> 
> I commented at the other bug in the meantime. Thiago already says it:
> > I know there is a patch on the review queue already. I ended up duplicating this work because the bugzilla was down today and I could not search if there was some work ongoing on this already. :(
> 
> Sorry for the unclear comment here. :-(

My patch conflicts with this one because I'm adding things from WebCore/testing to WebCore library. I agree we should ship it separately since doesn't make sense to add some bits to WebCore library just because a DRT dependency.

I'll rewrite my patch taking this one into account. Thank you guys for pointing this out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.