[Webkit-unassigned] [Bug 80104] New: ./Tools/Scripts/svn-apply fails while trying to process patch generated with png(binary) file.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 23:22:03 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80104

           Summary: ./Tools/Scripts/svn-apply fails while trying to
                    process patch generated with png(binary) file.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ssandela at innominds.com
                CC: kbolisetty at innominds.com, mrahaman at innominds.com


It is found that when we run 'svn-create-patch' involving a png file, the patch has following characters in it. 

Property changes on: abc.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+image/png


which svn-apply is not able to process. The above characters are footer data when 
"svn-diff --diff-cmd -diff abc.png" 
is run inside svn-apply, which VCSUtils.pm is not able to process.

Because of this, patches generated on Windows(Win-7, Cygwin, svn1.7.2) and Linux terminals are failing on build bots.

When svn-create-patch is run on MAC Machine, there is no such issue and it generates following kind of footer.

Property changes on: abc.png
___________________________________________________________________
Added: svn:mime-type
   + application/octet-stream

which is of-course being processed by svn-apply script through VCSUtils.pm file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list