[Webkit-unassigned] [Bug 80062] New: WebKit.gyp:webkit should not depend on test code (!)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 15:42:21 PST 2012


           Summary: WebKit.gyp:webkit should not depend on test code (!)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fischman at chromium.org

http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp&exact_package=chromium&q=file:gyp%20file:third_party/webkit%20:gtest&type=cs&l=710 makes the webkit target depend on test code in the shared-library build.

This is terrible for various reasons:
- It violates the ODR by whole-sale linking in static libraries which are also linked into the main binary directly (http://crbug.com/112539)
- It holds non-test code hostage to the standards of test-code (e.g. http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp&exact_package=chromium&q=file:gyp%20file:third_party/webkit%20:gtest&type=cs&l=763)
- It makes the build bigger than it needs to be

The madness must stop.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list