[Webkit-unassigned] [Bug 62698] Support for Battery Status API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62698


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129681|review?                     |review-
               Flag|                            |




--- Comment #34 from Gustavo Noronha (kov) <gns at gnome.org>  2012-03-01 08:49:57 PST ---
(From update of attachment 129681)
View in context: https://bugs.webkit.org/attachment.cgi?id=129681&action=review

> Tools/Scripts/build-webkit:320
> -      define => "ENABLE_SVG", default => 1, value => \$svgSupport },
> +      define => "ENABLE_SVG", default => 0, value => \$svgSupport },

You should not change these defaults, specially not in an unrelated patch.

> Tools/Scripts/build-webkit:326
> -      define => "ENABLE_SVG_FONTS", default => 1, value => \$svgFontsSupport },
> +      define => "ENABLE_SVG_FONTS", default => 0, value => \$svgFontsSupport },

Ditto.

> Tools/Scripts/build-webkit:344
> -      define => "ENABLE_VIDEO_TRACK", default => (isAppleWebKit() || isGtk()), value => \$videoTrackSupport },
> +      define => "ENABLE_VIDEO_TRACK", default => (isAppleWebKit() || isGtk() || isEfl()), value => \$videoTrackSupport },

Unrelated, better have it in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.