[Webkit-unassigned] [Bug 17450] in page anchor and keyboard navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17450





--- Comment #19 from Mario Sanchez Prada <msanchez at igalia.com>  2012-03-01 02:20:05 PST ---
(From update of attachment 129465)
View in context: https://bugs.webkit.org/attachment.cgi?id=129465&action=review

Thanks for the review. See some comments below...

>> LayoutTests/accessibility/anchor-link-selection-and-focus.html:35
>> +        shouldBe("getSelection().anchorNode.nodeValue", "'The Anchor'");
> 
> you should probably also check that the anchor is focused now

You're right. I'll add that in a follow-up patch.

>> Source/WebCore/accessibility/AXObjectCache.cpp:163
>> +{
> 
> is this only going to happen if accessibility is enabled?
> I'd think we'd want this to happen all the time for people using the keyboard to navigate as well (without a screen reader per se)

In its current form, "yes". This is because AXObjectCache::handleScrolledToAnchor() is called from FrameView::scrollToAnchor(), in the following fashion:

void FrameView::scrollToAnchor()
{
    [...]

    // Scroll nested layers and frames to reveal the anchor.
    // Align to the top and to the closest side (this matches other browsers).
    anchorNode->renderer()->enclosingLayer()->scrollRectToVisible(rect, ScrollAlignment::alignToEdgeIfNeeded, ScrollAlignment::alignTopAlways);

    if (AXObjectCache::accessibilityEnabled())
        m_frame->document()->axObjectCache()->handleScrolledToAnchor(anchorNode.get());

    [...]
}

I agree with you this issue is something that we want to get fixed across different platforms, but I'm not sure if changing the selection and focus is something that an user with a11y disabled would expect. After all keyboard navigation it's usually related (well, at least in GTK) to caret navigation, which is an accessibility feature, so maybe the expected behaviour when a11y is disabled is just to scroll the window (as it does now) and not do anything else.

Checking the W3C recommendation at http://www.w3.org/TR/html4/struct/links.html, I can't find any clue about whether updating the focus and selection is the expected normal behaviour, so I guess it's safe to fix this when a11y is enabled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.