[Webkit-unassigned] [Bug 79867] [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79867





--- Comment #3 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-01 00:12:12 PST ---
(In reply to comment #2)
> (From update of attachment 129411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129411&action=review
> 
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.h:172
> > +    ContentsLayerPurpose m_contentsLayerPurpose;
> 
> You should be able to compress this a bit by giving it 2 bits :
> ContentsLayerPurpose m_contentsLayerPurpose : 2;
> But make sure our compiler really decreases the object size, just try with sizeof before and after.

I tried the bit-field, but sizeof(GraphicsLayerBlackBerry) gives the same result. I prefer not to change it.

All the other comments will be addressed in a revised patch. Thank you very much!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.