[Webkit-unassigned] [Bug 90261] Move platform/qt/fast/js/navigator-language.html to fast/js.

Fri Jun 29 12:29:00 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=90261

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150154|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-29 12:28:58 PST ---
(From update of attachment 150154)
View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review

> LayoutTests/fast/js/navigator-language.html:10
> +    <head>
> +        <script src="../../fast/js/resources/js-test-pre.js"></script>
> +    </head>
> +    <body>
> +        <script>
> +            description(
> +                "<pre>Check return value of navigator.language."
> +            );

Why are you indenting elements and scripts like this? We don't normally do this.
Also, please use svn mv.

> LayoutTests/fast/js/navigator-language.html:18
> +				shouldBe("language", "'en'");

We use 4-space indentation, not tabs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.