[Webkit-unassigned] [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90264





--- Comment #13 from Andrey Kosyakov <caseq at chromium.org>  2012-06-29 07:55:57 PST ---
(From update of attachment 150169)
View in context: https://bugs.webkit.org/attachment.cgi?id=150169&action=review

>>> Source/WebCore/inspector/InspectorTimelineAgent.h:148
>>> +    static void setInstance(InspectorTimelineAgent* inspectorTimelineAgent) { **ThreadSpecificInstance() = inspectorTimelineAgent; }
>> 
>> Why is this public?
> 
> I would rather move this method to the InspectorInstrumentation.

Why would we want to introduce a cyclical dependency between InspectorTimelineAgent and InspectorInstrumentation and make a setInstance() method public on InspectorInstrumentation, when it only should be used by InspectorTimelineAgent? Incapsulating setInstance()/instance() in timeline agent reduces the public interface and minimizes dependencies.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.