[Webkit-unassigned] [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90264


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150169|review?                     |review-
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2012-06-29 07:25:18 PST ---
(From update of attachment 150169)
View in context: https://bugs.webkit.org/attachment.cgi?id=150169&action=review

> Source/WebCore/ChangeLog:8
> +        * inspector/InspectorInstrumentation.cpp:

Please explain what happens and why here?

> Source/WebCore/inspector/InspectorInstrumentation.h:410
> +

Please roll back this change.

>> Source/WebCore/inspector/InspectorTimelineAgent.h:148
>> +    static void setInstance(InspectorTimelineAgent* inspectorTimelineAgent) { **ThreadSpecificInstance() = inspectorTimelineAgent; }
> 
> Why is this public?

I would rather move this method to the InspectorInstrumentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.