[Webkit-unassigned] [Bug 90268] New: [WK2][GTK] Implement a new spell checker API for WebKit2GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90268

           Summary: [WK2][GTK] Implement a new spell checker API for
                    WebKit2GTK+
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: msanchez at igalia.com
                CC: xan.lopez at gmail.com, mrobinson at webkit.org,
                    cgarcia at igalia.com


As in the case of WK1, we need to implement a spell checker API in WebKit2GTK+ so apps needing this (e.g. epiphany) can migrate to WK2.

The idea would be to provide a new API client for the TextChecker, and provide at least the same functionality present in WK1.

After talking to Martin Robinson and Carlos García, it is not clear at this stage whether it would be interesting or not to expose the spell checker out of WK2GTK+, thus allowing apps using it directly and/or replacing it with another specific spell checker, so in the first iteration of the patch I will be proposing something like what we have in WK1, while we make up our minds on this.

Wrapping up, the current proposal would be something like this:

  * Implement new API client for the TextChecker:
    UIProcess/API/gtk/WebKitTextCheckerClient.*

  * Implement and expose a new interface for the spell checker:
    UIProcess/API/gtk/WebKitSpellChecker.*

  * Implement but DON'T expose a specific implementation, based in enchant:
    UIProcess/API/gtk/WebKitSpellCheckerEnchant

Last, I've just observed that in WK1 the TextCheckerClient is designed to be a global object, so I'll be associating the TextCheckerClient to the WebKitWebContext, instead of doing it to the WebView.

Also, because of this global nature, instead of creating WebKitSettings for wrapping 'enable-spell-checking' and 'spell-checking-languages' properties, which would link those properties to the WebView as in WK1 (and we don't want that, since spell checking is a global feature in WK2), I'll be handling those properties in WebKitWebContext, providing getters and setters for then (so the use can enable/disable it and change the list of languates).

Anyway, this is a first proposal and what I'll be basing my first patch in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.