[Webkit-unassigned] [Bug 90198] Port DFG JIT to traditional ARM
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 28 12:57:36 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90198
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-06-28 12:57:36 PST ---
Attachment 149988 did not pass style-queue:
Source/JavaScriptCore/dfg/DFGOperations.cpp:146: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:157: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:178: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:189: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:1384: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:1393: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.cpp:295: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/assembler/ARMAssembler.cpp:331: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:430: vmov_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:465: vabs_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:470: vneg_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:485: dtr_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:490: dtr_ur is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:495: dtr_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:500: dtr_dr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:505: dtrh_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:510: dtrh_ur is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:515: dtrh_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:520: dtrh_dr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:525: fdtr_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:532: fdtr_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:561: vmov_vfp64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:567: vmov_arm64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:573: vmov_vfp32_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:579: vmov_arm32_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:597: vcvt_u32_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:603: vcvt_f64_f32_r is incorrectly named. Don't use underscores in your identifieFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/assembler/ARMAssembl..." exit_code: 1
r names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:609: vcvt_f32_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:893: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:910: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:911: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:912: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:913: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:914: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:915: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 35 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list