[Webkit-unassigned] [Bug 90166] NEON intrinsics should be used with gaussian blur filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90166





--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2012-06-28 09:24:54 PST ---
(From update of attachment 149938)
View in context: https://bugs.webkit.org/attachment.cgi?id=149938&action=review

Looks sane to me in general, but I prefer that Zoltan looks at the NEON stuff, he can give r+ or r- then :-)

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:127
> +                boxBlurNEON(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());
> +            else
> +                boxBlur(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());

You could expand isAlphaImage() here.

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:138
> +                boxBlur(src, dst, kernelSizeY, dyLeft, dyRight, stride, 4, paintSize.height(), paintSize.width(), isAlphaImage());

boxBlurNEON? Otherwise this makes no sense.
You could also expand isAlphaImage() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.