[Webkit-unassigned] [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84540


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |rgf748 at motorola.com
                   |kit.org                     |
 Attachment #138573|0                           |1
        is obsolete|                            |
 Attachment #138573|review?                     |
               Flag|                            |
 Attachment #149931|                            |review?
               Flag|                            |




--- Comment #29 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2012-06-28 05:15:38 PST ---
Created an attachment (id=149931)
 --> (https://bugs.webkit.org/attachment.cgi?id=149931&action=review)
updatedPatchWithTraits

Updated patch to simplify the JSDOMBinding.h and V8Binding.h replacing specialised functions with traits.
So in future if someone wants to add jsArray() for new datatype need not to write jsArray() again.
eg. For "unsigned int" it needs to add below code only.
   template<>
    struct traits<unsigned int> {
        static inline JSC::JSValue arrayJSValue(JSC::ExecState* , JSDOMGlobalObject*, const unsigned int& value)
        {
            return JSC::jsNumber(value);
        }
    };
Same for V8Binding too.

Also now I don't see the dependency of this bug for Bug84929. Can we remove it from block list?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.