[Webkit-unassigned] [Bug 90054] [EFL][WK2] Make ewk_view inheritable in the WebKit2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90054


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dumez at intel.com




--- Comment #6 from Christophe Dumez <christophe.dumez at intel.com>  2012-06-28 03:47:12 PST ---
(From update of attachment 149705)
View in context: https://bugs.webkit.org/attachment.cgi?id=149705&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_page_group.cpp:40
> +    if (!ewkPageGroup)

Shouldn't we use EINA_SAFETY_ON_NULL_RETURN_VAL(ewkPageGroup, 0); ? Passing NULL is not valid API use IMHO.

> Source/WebKit2/UIProcess/API/efl/ewk_view_private.h:39
> +Evas_Object* ewk_view_add_with_WKContext_and_WKPageGroup(Evas*, WKContextRef, WKPageGroupRef);

Can't we make this function name a bit shorter? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.