[Webkit-unassigned] [Bug 88196] REGRESSION (r96393): In some cases, generated content is never shown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88196





--- Comment #10 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-06-28 03:25:29 PST ---
(In reply to comment #8)
> (From update of attachment 148539 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148539&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        (WebCore::SelectorChecker::checkOneSelector):
> > +        While obtaining the shared style (if any) for the current element we return false from
> > +        checkOneSelector() for the pseudo-element case. This is because our SelectorChecker's
> > +        mode is set to that of ResolvingStyle and we thus fail the initial condition check.
> > +
> > +        To avoid the same have added another value (SharingRules) to the Mode enum and the same
> > +        can be set for the SelectorChecker before calling on locateSharedStyle().
> 
> I don't understand the logic of this fix. The explanation here is not particularly enlightening. What exactly is the problem and how does the patch solve it?

Thanks for the review Antti. I agree, the explanation here was not really sufficient; my apologies for that.
Have uploaded another patch with a more detailed explanation in the ChangeLog which hopefully shall provide some more insight into the fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.