[Webkit-unassigned] [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89666


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149754|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Simon Hausmann <hausmann at webkit.org>  2012-06-27 22:18:02 PST ---
(From update of attachment 149754)
View in context: https://bugs.webkit.org/attachment.cgi?id=149754&action=review

I do think that the idea is good, but I don't think the implementation is correct.

This is not an issue that is specific to the Qt port, so support for this should be present for all ports using WTR. And that appears to be the case, given that WTR's TestController.cpp already has code for reading the DUMPRENDERTREE_TEMP variable and then uses WKContextSetDatabaseDirectory to direct the databases to the location pointed to by the environment variable.

I suspect that what's happening in our case is that we end up running our initialization code afterwards and over-write the previously set database directory - for example the PlatformWebView is created after the call to the C API.

Consequently I think the cleanest fix would involve us correctly taking the existing cross-platform code path.

> Source/WebKit2/ChangeLog:4
> +        [Qt] Separate WebKit2 instances use the same local storage
> +        https://bugs.webkit.org/show_bug.cgi?id=89666

Can you elaborate a bit more (either in the changelog or bugzilla) what the _symptom_ is that you're trying to fix?

Is this an issue when using NWRT with multiple WTR instances writing to the same directory?

> Tools/ChangeLog:9
> +        directory.If ther is the DUMPRENDERTREE_TEMP environment

Space between punctuation and the If. And "ther" -> "there" :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.