[Webkit-unassigned] [Bug 90074] Don't malloc RenderGeometryMap steps individually

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90074





--- Comment #7 from Antti Koivisto <koivisto at iki.fi>  2012-06-27 14:39:06 PST ---
> How is this copyable, since it has an OwnPtr<>. Doesn't using it in a Vector by value require that it's copyable?

SimpleClassHashTraits should make it safe. Vector doesn't need copying, just moving, and moving with memcpy/memmove works just fine with OwnPtr. The same reason pure Vector<OwnPtr<Foo>> works basically (which also has SimpleClassHashTraits). 

I'll see about the test failures though.

> Also, does the copy cost show up on profiles, since we insert before the end often?

I'll check but that seems unlikely. The inserts are rarely very far from the end and the type is not particularly big.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.