[Webkit-unassigned] [Bug 90019] [chromium] Add time spent painting to GPU benchmarking renderingStats() API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90019





--- Comment #6 from Nat Duca <nduca at chromium.org>  2012-06-27 06:58:42 PST ---
(From update of attachment 149624)
View in context: https://bugs.webkit.org/attachment.cgi?id=149624&action=review

There's an interesting question of what this should report in skpicture/impl-side-painting mode.

These are different quantities in that case:
- time spent painting
- time spent rasterizing

In the regular "rasterize as you go mode" (bitmapcanvaslayertextureupdater) mode, should we just say "rasterizing time is zero"?

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:471
>> +    m_timeSpentPainting = monotonicallyIncreasingTime() - updateBeginTime;
> 
> updateLayers() covers more than just painting.  for instance, a canvas 2d layer will do a flush here, image layers will prepare texture uploads, WebGL layers will issue multisample resolves etc

You're clobbering this every frame. That means we can only get the time spent painting in the last frame.

Should we instead be accumulating to this value? E.g. so we track the time we've spent paiting ever? That way we can check it twice and from the deltas, get the real time spent painting.

And, if thats the case, should we be concerned about numeric precision as this number gets larger?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.