[Webkit-unassigned] [Bug 87734] REGRESSION (r118735): svg/dom/complex-svgView-specification.html, svg/dom/SVGViewSpec.html, svg/dom/viewspec-parser.html failing on GTK Linux 64-bit Release

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87734





--- Comment #6 from Dan Winship <danw at gnome.org>  2012-06-27 06:06:01 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > ah, ok, if you want *no* %-escaping, you should use soup_uri_decode(), not soup_uri_normalize().
> 
> Using soup_uri_decode causes regressions, for instance %3D gets converted back to = and similar (see test cases [1] and [2])

So you *don't* want no %-escaping. :)

> soup_uri_normalize, with the space character as an extra unreserved character to decode, does the trick with no test regressions, but I'm not sure it's the correct way of handling the issue.

It's at least right-ish. There may be other characters you need in the "extra unreserved" list that just don't get tested by the current set of tests... It seems like this would be something that it would be good to have SVGViewSpec::parseViewSpec() explicitly document.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.