[Webkit-unassigned] [Bug 89987] [GTK] Enable MHTML support by default at build time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89987


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149545|0                           |1
        is obsolete|                            |
 Attachment #149554|0                           |1
        is obsolete|                            |
 Attachment #149545|review?                     |
               Flag|                            |
 Attachment #149554|review?                     |
               Flag|                            |
 Attachment #149701|                            |review?
               Flag|                            |




--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2012-06-27 01:16:08 PST ---
Created an attachment (id=149701)
 --> (https://bugs.webkit.org/attachment.cgi?id=149701&action=review)
Patch proposal

(In reply to comment #4)
> [..·]
> I'm providing another patch with this approach now, not marking the previous one as obsolete yetm in case it was preferred.
> 
> One doubt I have at this point is whether I need to do also the change in the perl file or not. Any hint?

I've double checked this and, indeed, we need to modify both configure.ac and Tools/Scripts/webkitperl/FeatureList.pm:

 - configure.ac: To enable MHTML by default when using ./configure && make
 - Tools/Scripts/webkitperl/FeatureList.pm: To enable MHTML by default when using the build-webkit script.

If I just modify configure.ac, build-webkit will override the default value with its own value.

To be more sure I checked how WebGL feature was enabled by default at build time and found two relevant commits:

 - SVN r101060: Enable WebGL by default (in configure.ac)
 - SVN r116310: WebGL feature is not built anymore through build-webkit after r116251 (in FeatureList.pm)

It seems changing configure.ac (at least for WebGL) used to be enough until r116251, when WebGL was introduced in FeatureList.pm. Makes sense, I think.

So, attaching a new single patch with the two changes in it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.