[Webkit-unassigned] [Bug 89639] [EFL] Change format of return value of navigator.language

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89639





--- Comment #18 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-06-26 21:26:28 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > Yes, I don't like keeping two almost identical copies of the same test in the tree; if the test also applies to ports other than Qt, it should be moved back to fast/js with a proper explanation (and perhaps skipped in ports where it does not make sense), otherwise another, specific test should be written.
> 
> Basically, you are absolutely right.
> But, in this case, return value of navigator.language is different in each ports.
> For example, chromium-win port never pass this test case because of difference of return value.
> Therefore, I think it is better test case adds under platform/efl.
> (I can simplify my test case but it is not much different with qt because this is very simple patch and test.(Actually I don't think this test is really needed.)
> How do you think about this?

I still think that if Qt's test is still relevant for other ports, it's better to move it back to the main LayoutTests directory to prevent needless duplication of tests (you can talk to the people who added the tests and/or to the ones who moved it to platform/qt before that as well to confirm that this makes sense).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.