[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003





--- Comment #35 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-06-26 21:05:31 PST ---
(In reply to comment #34)
> (In reply to comment #32)
> > (In reply to comment #31)
> > > > Source/WebCore/bindings/js/ScriptDebugServer.cpp:157
> > > > +    int nextColumn = codeInLine.find(";", m_currentStatementPosition.columnNumber);
> > > 
> > > You shouldn't be trying to parse the code here, instead JSC should be extended to report you current statement's column.
> > > 
> > It's a very big change to make JSC to provide current statement's column. Since JSC doesn't really insert break point, it just call interface of Debugger at entrance of Function or code-block. 
> > And actually, the Debugger has enough info to calculate it.
> I doubt it. E.g. how can you tell in ScriptDebugServer which column is going to be next in the following statement: "if (foo()) { bar(); } else { baz(); }" ?
Yes, my code is failed with that case. I thought JSC will take code inside curved parentheses as a code-block. I'm wrong :(. Maybe, it's impossible to solve it keeping JSC unchanged?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.