[Webkit-unassigned] [Bug 88665] Favicon URL list sent with favicon updated message contains out of date icon URLs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88665





--- Comment #56 from Kent Tamura <tkent at chromium.org>  2012-06-26 19:19:55 PST ---
(From update of attachment 149563)
View in context: https://bugs.webkit.org/attachment.cgi?id=149563&action=review

> Source/WebCore/dom/Document.cpp:4847
> +        if (!equalIgnoringCase(linkElement->type(), iconMIMEType) || !(linkElement->iconType() == Favicon))

nit: !(linkElement->iconType() == Favicon) looks strange.  Why not linkElement->iconType() != Favicon ?

> Source/WebCore/loader/icon/IconController.cpp:89
> +    // Start by adding the favicon from the current document if we have one, if not, use the default favicon.

This change looks unnecessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.