[Webkit-unassigned] [Bug 89248] [cairo] simplify copyCairoImageSurface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89248





--- Comment #8 from arno. <arno at renevier.net>  2012-06-26 17:45:54 PST ---
(In reply to comment #7)

> So it seems that, in the best case, we save just over one half of a millisecond and that's with the creation of a very large pattern. I would feel much better about this kind of micro-optimization if it showed some kind of user-observable speedup. 

Yes, the performance improvement is really negligible.

> There's a benefit to abstraction and using the API of your dependencies. I think that benefit outweighs the benefit of micro-optimization when the optimization has little effect on the user experience.

The current code use image-surface specific apis either for originalSurface and for newSurface. So, I really hadn't the feeling that my patch were decreasing the abstraction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.