[Webkit-unassigned] [Bug 89759] [CSSRegions]Change display values that allow regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89759


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149492|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Tony Chang <tony at chromium.org>  2012-06-26 13:35:03 PST ---
(From update of attachment 149492)
View in context: https://bugs.webkit.org/attachment.cgi?id=149492&action=review

> LayoutTests/fast/regions/script-tests/region-element-display-change.js:26
> +shouldBeFalse('testElement(element, "inline-table")');
> +shouldBeTrue('testElement(element, "table-cell")');
> +shouldBeTrue('testElement(element, "table-caption")');
> +shouldBeTrue('testElement(element, "list-item")');

Nit: I would go ahead and add all the other display types here.

> Source/WebCore/rendering/RenderObject.cpp:154
> +    if (doc->cssRegionsEnabled() && style->isDisplayRegionType() && !style->regionThread().isEmpty() && doc->renderView())
> +        return new (arena) RenderRegion(node, doc->renderView()->flowThreadController()->ensureRenderFlowThreadWithName(style->regionThread()));

Please watch the perf results at http://webkit-perf.appspot.com/ after this lands. I don't expect there to be a regression, but it's good to be ready.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.